Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifying workspaces for tools and others #41601

Closed
ishitatsuyuki opened this issue Apr 28, 2017 · 2 comments
Closed

Unifying workspaces for tools and others #41601

ishitatsuyuki opened this issue Apr 28, 2017 · 2 comments

Comments

@ishitatsuyuki
Copy link
Contributor

Compiling cargo is known to be slow as hell, and it would be better if we build less.

I'm proposing here to make a cargo workspace for all the stage2 tools. This way,

  • If well configured, Cargo will only be built once (shared with RLS build artifacts)
  • More parallelism since there's more crates to build at once and less likely to block on single big crate

Also, I'm not sure if it's possible, but grouping std, rustc and minor tools can also improve a bit.
@ishitatsuyuki
Copy link
Contributor Author

@alexcrichton I would appreciate some discussion here. By the way, the dream is blocked by rust-lang/cargo#3976.

BTW, I'm currently working on a local PoC.

@alexcrichton
Copy link
Member

I don't really understand what the issue here is about, but faster builds are faster builds!

@ishitatsuyuki ishitatsuyuki mentioned this issue Apr 29, 2017
Merged
bors added a commit that referenced this issue May 17, 2017
@bors
Auto merge of #41639 - ishitatsuyuki:unify-tools, r=alexcrichton
be1d1aa 
Unify tools building

Close #41601

Time saving for up to 10 minutes. Cargo is now only compiled once.

Downsides:

- Out of tree Cargo.lock maintenance
- Cargo.toml `[replace]` version maintenance
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 17, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41639 - ishitatsuyuki:unify-tools, r=alexcr…
02cc460 
…ichton

Unify tools building

Close rust-lang#41601

Time saving for up to 10 minutes. Cargo is now only compiled once.

Downsides:

- Out of tree Cargo.lock maintenance
- Cargo.toml `[replace]` version maintenance
bors added a commit that referenced this issue May 18, 2017
@bors
Auto merge of #41639 - ishitatsuyuki:unify-tools, r=alexcrichton
31bfa96 
Unify tools building

Close #41601

Time saving for up to 10 minutes. Cargo is now only compiled once.

Downsides:

- Out of tree Cargo.lock maintenance
- Cargo.toml `[replace]` version maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @ishitatsuyuki