Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokei 6.0.0 won't compile on nightly #41685

Closed
mzji opened this issue May 1, 2017 · 4 comments
Closed

tokei 6.0.0 won't compile on nightly #41685

mzji opened this issue May 1, 2017 · 4 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@mzji
Copy link

mzji commented May 1, 2017 •
edited
Loading

OS: Win10 Home x64 version 1607 / build 10.0.14393, Build Tools for Visual Studio 2017
rustc metadata:

C:\>rustc -vV
rustc 1.19.0-nightly (06fb4d256 2017-04-30)
binary: rustc
commit-hash: 06fb4d25642a3f223db1441972dd5962085cfba1
commit-date: 2017-04-30
host: x86_64-pc-windows-msvc
release: 1.19.0-nightly
LLVM version: 4.0

Error messages during installing tokei via cargo:

(unreleated lines removed)
   Compiling tokei v6.0.0
LLVM ERROR: No open Win64 EH frame function!
error: failed to compile `tokei v6.0.0`, intermediate artifacts can be found at `C:\Users\USERNAME\AppData\Local\Temp\cargo-install.APq02cIhSEk9`

Caused by:
  Could not compile `tokei`.

To learn more, run the command again with --verbose.
@nagisa nagisa added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2017
@TimNN TimNN added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 3, 2017
@TimNN
Copy link
Contributor

TimNN commented May 3, 2017 •
edited
Loading

Potentially related to #41630.

Looks like https://bugs.llvm.org/show_bug.cgi?id=32335, in which case this should be fixed by llvm-mirror/llvm@3993050.

I'll see if backporting that patch fixes the issue. Nevermind that part, I don't have a windows machine available right now.

This was referenced May 4, 2017
Merged
Merged
@brson
Copy link
Contributor

brson commented May 4, 2017

Needs verification after llvm backport lands.

@brson brson added the P-high High priority label May 4, 2017
bors added a commit that referenced this issue May 4, 2017
@bors
Auto merge of #41739 - TimNN:update-llvm, r=aturon
59f1a2f 
Update llvm to pull in various backports

Fixes #41672
Fixes #41630
Fixes #41685
@TimNN
Copy link
Contributor

TimNN commented May 6, 2017

@mzji: Can you try again with the latest nightly? That should fix the issue.

@mzji
Copy link
Author

mzji commented May 6, 2017 •
edited
Loading

@TimNN Ok, I'm testing now
Yay, it's fixed! Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brson @nagisa @TimNN @mzji