Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change internalize_symbols to work per-CGU #41707

Closed
nikomatsakis opened this issue May 2, 2017 · 2 comments
Closed

change internalize_symbols to work per-CGU #41707

nikomatsakis opened this issue May 2, 2017 · 2 comments
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Right now internalize_symbols() walks over all of the generated LLVM IR to decide what is internal. This only happens in non-incremental mode. However, it is a blocker to moving to a pipelined setup, because it requires all of the modules to be in a big array. Ideally, we would refactor things so that we figure out during trans item collection what may be marked internal or not (though in incremental mode we may prefer to mark everything public so as to have more reuse). However, another alternative would be to hack something up so that we disable pipelining when not in incremental mode.

cc @michaelwoerister

@nikomatsakis nikomatsakis added A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2017
@michaelwoerister
Copy link
Member

cc #39280

@michaelwoerister
Copy link
Member

Implemented in #43183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants