You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Unlike the C versions these copy a number of elements, not bytes. Seemed like a good idea at the time but confused me today when I couldn't remember. Let's rename them to be clear that they are not the same as C.
I don't have any great ideas for the names at this moment.
The text was updated successfully, but these errors were encountered:
These are unsafe functions, so they can copy anything, not just POD. I also noticed that vec::raw::memcpy, etc. have this same issue, they copy elements, not bytes. Interestingly, the vec docs incorrectly claim that they copy bytes.
As discussed on IRC, calling these anything other than memcpy and memmove makes it less clear what the distinction between the two is. The pair have very well known properties regarding overlapping memory.
So any other name should indicate that distinction. I'm wondering if it's best to keep these names after all.
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Unlike the C versions these copy a number of elements, not bytes. Seemed like a good idea at the time but confused me today when I couldn't remember. Let's rename them to be clear that they are not the same as C.
I don't have any great ideas for the names at this moment.
The text was updated successfully, but these errors were encountered: