-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntoIterator and FromIterator say "module level documentation" but link to traits #42267
Comments
I think it's the opposite: it should really link to the iterator module level, not to the traits. |
Yes, I second @GuillaumeGomez here. I'd be happy to mentor anyone who wants to make a PR for this. |
Ok, I could make a PR (I'm happy once again to be mentored!). Just to be sure before fixing link: does the "module-level" refers to https://doc.rust-lang.org/stable/std/iter/ (i.e replacing EDIT: reading https://github.com/rust-lang/rust/blob/master/src/libcore/iter/iterator.rs#L26 I'm pretty sure it's OK so I sent a PR. If you think I should leave it to another person who needs mentoring, I can close. |
You did it right 👍 |
fix links to "module-level documentation" see rust-lang#42267
Should we close this issue? |
Yes! |
At https://github.com/rust-lang/rust/blob/master/src/libcore/iter/traits.rs#L112 and https://github.com/rust-lang/rust/blob/master/src/libcore/iter/traits.rs#L220, there's text:
However, the links go to
trait.FromIterator.html
andtrait.IntoIterator.html
.Would it be an alright change to have these say
See the [trait-level documentation] for more information.
instead?The text was updated successfully, but these errors were encountered: