Skip to content

Do shallow clones of submodules in x.py #42442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjorn3 opened this issue Jun 5, 2017 · 4 comments
Closed

Do shallow clones of submodules in x.py #42442

bjorn3 opened this issue Jun 5, 2017 · 4 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jun 5, 2017

https://git-scm.com/docs/git-submodule#git-submodule---depth
@bjorn3 bjorn3 changed the title Do shallow clones of submodules Do shallow clones of submodules in x.py Jun 5, 2017
@est31
Copy link
Member

est31 commented Jun 5, 2017

I think that has been tried but was abandoned because switching back to some older revision didn't work well.

@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 5, 2017
@est31
Copy link
Member

est31 commented Jun 5, 2017

cc #42208

@Mark-Simulacrum
Copy link
Member

Yeah, this wouldn't really work since we don't know what depth we need to get the commit we want in each submodule. I don't think this is viable -- and we should probably just close it, though if anyone has ideas I want to hear them so I'll leave it open for now.

@Mark-Simulacrum
Copy link
Member

Closing -- this doesn't work in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mark-Simulacrum @est31 @bjorn3