Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inference regression in rustc 1.18 #42545

Closed
khuey opened this issue Jun 8, 2017 · 8 comments
Closed

Type inference regression in rustc 1.18 #42545

khuey opened this issue Jun 8, 2017 · 8 comments
Assignees
Labels
P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@khuey
Copy link
Contributor

khuey commented Jun 8, 2017

https://github.com/khuey/rustc-1.18-regression

I'm not sure that this is a minimal testcase, but it's small enough to poke around at. With rustc 1.17 this compiles fine. With 1.18 I get

error[E0284]: type annotations required: cannot resolve `<_ as futures::IntoFuture>::Future == _`
  --> src/lib.rs:15:18
   |
15 |           Box::new(join_all(vec2.iter()
   |  __________________^
16 | |                           .map(move |_| {
17 | |                               iter::<_, _, ()>(vec1.iter()
18 | |                                                .filter_map(move |_| {
...  |
24 | |                                   })
25 | |                           })))
@frewsxcv frewsxcv added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jun 8, 2017
@nikomatsakis nikomatsakis modified the milestone: t-com Jun 8, 2017
@nikomatsakis nikomatsakis added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2017
@frewsxcv
Copy link
Member

frewsxcv commented Jun 8, 2017

For posterity, this is also broken on the latest nightly as well

rustc 1.19.0-nightly (f062832b2 2017-06-07)
binary: rustc
commit-hash: f062832b208e94f2f0f26ed7fb5c48c172069fbe
commit-date: 2017-06-07
host: x86_64-apple-darwin
release: 1.19.0-nightly
LLVM version: 4.0

@nikomatsakis
Copy link
Contributor

triage: P-high -- regression

@rust-highfive rust-highfive added P-high High priority and removed I-nominated labels Jun 8, 2017
@nikomatsakis nikomatsakis self-assigned this Jun 8, 2017
@Mark-Simulacrum
Copy link
Member

Bisected to 141e8a6, #41716 -- cc @nikomatsakis.

@nikomatsakis
Copy link
Contributor

Well, I can certainly reproduce it =)

@nikomatsakis
Copy link
Contributor

This may be a dup of #42552

@nikomatsakis
Copy link
Contributor

My fix for #42552 also fixes this.

@bors bors closed this as completed in 9fec409 Jun 17, 2017
@khuey
Copy link
Contributor Author

khuey commented Jun 19, 2017

Is the fix going to make it into 1.19? A 1.18.1?

@Mark-Simulacrum
Copy link
Member

The PR (#42659) is beta-nominated, so if it's accepted the fix will be backported and make it into 1.19. However, I doubt we'd release 1.18.1 -- it's possible, though.

brson pushed a commit to brson/rust that referenced this issue Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants