-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Open
Labels
A-local-reexportsArea: Documentation that has been locally re-exported (i.e., non-cross-crate)Area: Documentation that has been locally re-exported (i.e., non-cross-crate)C-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
Test case:
mod internal {
pub struct BadName;
impl BadName {
pub fn f(&self) {}
}
}
pub use internal::BadName as GoodName;Running rustdoc a.rs, it produces this page:
Note that the impl still refers to the struct as BadName. The fix for #34473 is not enough.
Real world example:
- https://docs.rs/handlebars/6.3.2/handlebars/struct.Handlebars.html — the struct is exported as
Handlebarsbut the content saysimpl Registry. The methodnew()also returnsRegistry. - https://docs.rs/handlebars/6.3.2/handlebars/trait.HelperDef.html — the parameter involving
&'regrefers toRegistry, although it correctly links tostruct.Handlebars.html.
Metadata
Metadata
Assignees
Labels
A-local-reexportsArea: Documentation that has been locally re-exported (i.e., non-cross-crate)Area: Documentation that has been locally re-exported (i.e., non-cross-crate)C-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
