Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: improve error messages for IDEs #42823

Closed
4 of 6 tasks
nrc opened this issue Jun 22, 2017 · 5 comments
Closed
4 of 6 tasks

Tracking issue: improve error messages for IDEs #42823

nrc opened this issue Jun 22, 2017 · 5 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@nrc
Copy link
Member

nrc commented Jun 22, 2017

This is just a grab bag of things that would improve errors in IDEs via the RLS. These all apply to JSON errors rather than human-readable ones, where that's relevant

  • replace help with suggestions where possible
  • add suggestions that are not user-visible in human-readable output (e.g., to delete unused functions)
  • add suggestions in general (in particular, imports for name resolution errors)
  • implement the rendered field for all error types (currently only used by suggestions)
  • make sure the main error message reads well by itself without any span labels
  • if possible, suggestion labels should describe the action rather than the problem

cc @oli-obk @killercup @jonathandturner @est31

@nrc nrc added A-diagnostics Area: Messages for errors, warnings, and lints T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jun 22, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Jun 22, 2017

I already added import suggestions in #41876 and am improving more name resolution errors in #42033, but there's an inherent issue with the current name resolution impl and reporting path suggestions ( see PR for details)

@nrc
Copy link
Member Author

nrc commented Jun 22, 2017

I'm assuming the inherent issue is #42033 (comment)

My impression is that there are suggestions for some name resolution errors, but not all of them? And thus that there is still work to do here (I would like to nail this down more precisely).

cc @jseyfried too

@oli-obk
Copy link
Contributor

oli-obk commented Jun 22, 2017

Yes that is the issue description. The entire error reporting in resolve needs to be revamped I think.

I was trying to add them incrementally, as to not produce an immense unmanageable PR. These kind of changes produce a lot of churn in ui tests

@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2018

The 4th box has been implemented in #46052

@estebank
Copy link
Contributor

estebank commented Apr 8, 2019

I believe all the actionable items in this ticket have already been addressed and the last two are ongoing concerns that belong in documentation, not an open ticket. Does anyone have an objection to closing this ticket?

@oli-obk oli-obk closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants