Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicode_chars.rs should be updated to match the latest confusables document #43629

Closed
est31 opened this issue Aug 3, 2017 · 2 comments · Fixed by #43698
Closed

unicode_chars.rs should be updated to match the latest confusables document #43629

est31 opened this issue Aug 3, 2017 · 2 comments · Fixed by #43698
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@est31
Copy link
Member

est31 commented Aug 3, 2017 •
edited
Loading

src/libsyntax/parse/lexer/unicode_chars.rs contains a list of confusable characters (see #25957). Its comments mention that it bases on a document. Of this document, a newer revision has been published (link). It contains many more confusables, e.g. ᐸ (canadian syllabics Pa). We should update unicode_chars.rs to include the newly listed confusables as well.

Bug report inspired by this reddit post.
@est31
Copy link
Member Author

est31 commented Aug 3, 2017

As there has been #33128, the person fixing this bug shouldn't just apply a script and regenerate from scratch, but go through the new confusables.txt and add the new characters manually.

@MaloJaffre
Copy link
Contributor

I will try to work on this, because I have a lot of patience 😄

@Mark-Simulacrum Mark-Simulacrum added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Aug 3, 2017
MaloJaffre added a commit to MaloJaffre/rust that referenced this issue Aug 6, 2017
@MaloJaffre
Update the list of confusable characters
4e2ddcb 
Also reorder and space the list to make it clearer for futures updates
and to come closer to the original list.

Thanks @est31 for the instructions.

Fixes rust-lang#43629.
r? @est31
@MaloJaffre MaloJaffre mentioned this issue Aug 6, 2017
Merged
bors added a commit that referenced this issue Aug 8, 2017
@bors
Auto merge of #43698 - MaloJaffre:confusables, r=eddyb
ddc02de 
Update the list of confusable characters

Also reorder and space the list to make it clearer for futures updates
and to come closer to the original list.

This was tedious but somewhat rewarding!

Thanks @est31 for the instructions.

Fixes #43629.
r? @est31
@est31 est31 mentioned this issue May 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the list of confusable characters MaloJaffre/rust
3 participants
@Mark-Simulacrum @est31 @MaloJaffre