Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm-0.2.3 beta regression #43667

Closed
est31 opened this issue Aug 5, 2017 · 2 comments
Closed

glm-0.2.3 beta regression #43667

est31 opened this issue Aug 5, 2017 · 2 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

glm version 0.2.3 regressed from stable to beta (full log):

 	error[E0034]: multiple applicable items in scope
  --> <anon>:4:17
   |
 4 | assert_eq!(1i32.min(2i32), 1i32);
   |                 ^^^ multiple `min` found
   |
   = note: candidate #1 is defined in an impl of the trait `std::cmp::Ord` for the type `&_`
   = note: candidate #2 is defined in an impl of the trait `std::cmp::Ord` for the type `&mut _`
   = note: candidate #3 is defined in an impl of the trait `std::iter::Iterator` for the type `&mut _`
   = note: candidate #4 is defined in an impl of the trait `std::cmp::Ord` for the type `i32`
   = note: candidate #5 is defined in an impl of the trait `glm::BaseNum` for the type `i32`

cc @dche

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Aug 10, 2017
@alexcrichton
Copy link
Member

The libs team decided today that this is accepted breakage, so I'm going to close. cc @KodrAus though if you'd like to send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants