Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite compiletest to use Command liberally #43762

Closed
alexcrichton opened this issue Aug 9, 2017 · 2 comments
Closed

Rewrite compiletest to use Command liberally #43762

alexcrichton opened this issue Aug 9, 2017 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@alexcrichton
Copy link
Member

Believe it or not but the compiletest project predates the usage of Command in the standard library. We currently pass through tons of variables in tons of places, eventually culminating in creating a Command at the very end. We should instead thread through a Command everywhere to make argument passing much nicer!

That way we also don't need functions with seven arguments!
@alexcrichton alexcrichton added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 9, 2017
@euclio
Copy link
Contributor

euclio commented Aug 9, 2017

I'd like to work on this.

@alexcrichton
Copy link
Member Author

Awesome thanks @euclio! If you've got any questions please don't hesitate to ask!

This was referenced Aug 11, 2017
Closed
Merged
bors added a commit that referenced this issue Aug 24, 2017
@bors
Auto merge of #43907 - euclio:command, r=alexcrichton
a125ec9 
Use std::process::Command throughout compile-test

Resubmission of #43798.

Fixes #43762.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @euclio