Skip to content

Privatize appropriate struct fields in core and std #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bstrie opened this issue Jan 8, 2013 · 4 comments
Closed

Privatize appropriate struct fields in core and std #4386

bstrie opened this issue Jan 8, 2013 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@bstrie
Copy link
Contributor

bstrie commented Jan 8, 2013

< bstrie> pcwalton: do you know why priv is commented out on this line in
          std::future? 
          https://github.com/mozilla/rust/blob/master/src/libstd/future.rs#L30
<@brson> bstrie: because the priv keyword wasn't supported there at the
         time. it's a reminder that that field should be 'priv'
< bstrie> ok, so that should be changed then
<@brson> yes

Find all priv fields of this type and uncomment them. Should perhaps also go through the rest of the libraries and stick priv qualifiers wherever their use may have been overlooked.

@wting
Copy link
Contributor

wting commented Jan 11, 2013

Trying to add priv to this line causes the error: error: unmatched visibility. I'm not sure what that means though...

Also, how would we know where it's appropriate to add priv qualifiers?

Edit: Never mind about the 1st point:

< strcat> wting: I don't think you can make the extern mod stuff not get re-exported atm

@catamorphism
Copy link
Contributor

(bug triage) Still an issue; good easy starter project.

@pnkfelix
Copy link
Member

triage, email from 2013-09-09. Nothing to add.

@brson
Copy link
Contributor

brson commented Oct 30, 2013

This is done I think thanks to @reedlepee123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

5 participants