Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incremental: Hide lang_items behind a query in the TyCtxt #44190

Closed
alexcrichton opened this issue Aug 30, 2017 · 2 comments
Closed

incremental: Hide lang_items behind a query in the TyCtxt #44190

alexcrichton opened this issue Aug 30, 2017 · 2 comments
Assignees
@alexcrichton
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Right now this is calculated and passed into the TyCtxt, let's convert this to a query and then calculate it on-demand!

This'll also allow us to remove CrateStore::{lang_items, missing_lang_items} and convert them to queries as well.
@alexcrichton alexcrichton added the A-incr-comp Area: Incremental compilation label Aug 30, 2017
@nikomatsakis nikomatsakis mentioned this issue Aug 30, 2017
Closed
@nikomatsakis
Copy link
Contributor

cc me

@nikomatsakis nikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 30, 2017
@alexcrichton alexcrichton self-assigned this Aug 31, 2017
@alexcrichton
Copy link
Member Author

I've implemented this on a local branch, will post it soon

@alexcrichton alexcrichton mentioned this issue Sep 1, 2017
Merged
@shepmaster shepmaster added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Sep 1, 2017
bors added a commit that referenced this issue Sep 7, 2017
@bors
Auto merge of #44142 - alexcrichton:dllimport-query, r=nikomatsakis
81c72bc 
Migrate a slew of metadata methods to queries

This PR intends to make more progress on #41417, knocking off some low-hanging fruit.

Closes #44190
cc #44137
bors added a commit that referenced this issue Sep 8, 2017
@bors
Auto merge of #44142 - alexcrichton:dllimport-query, r=nikomatsakis
dead08c 
Migrate a slew of metadata methods to queries

This PR intends to make more progress on #41417, knocking off some low-hanging fruit.

Closes #44190
cc #44137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @nikomatsakis @shepmaster