Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenStream should implement Extend #44241

Closed
nox opened this issue Sep 1, 2017 · 2 comments
Closed

TokenStream should implement Extend #44241

nox opened this issue Sep 1, 2017 · 2 comments
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nox
Copy link
Contributor

nox commented Sep 1, 2017 

impl<T> Extend<T> for TokenStream
where
    T: Into<TokenStream>;

This would allow servo/servo#18340 to be written in a slightly better way.
@shepmaster shepmaster added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2017
@Arnavion
Copy link

Arnavion commented Sep 4, 2018

#53304 added Extend<TokenTree> and Extend<TokenStream>

@SimonSapin
Copy link
Contributor

Closing as I think #53304 would be good enough for servo/servo#18340. @nox, feel free to re-open or comment if you think the more generic form would still be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nox @shepmaster @SimonSapin @Arnavion