Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incr.comp.: Implement force_from_dep_node() in a macro. #45015

Closed
michaelwoerister opened this issue Oct 4, 2017 · 1 comment
Closed

incr.comp.: Implement force_from_dep_node() in a macro. #45015

michaelwoerister opened this issue Oct 4, 2017 · 1 comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@michaelwoerister
Copy link
Member

The ty::maps::plumbing::force_from_dep_node() procedure (introduced in #44901) is manually implemented right now. This is unfortunate, since it contains an exhaustive match over all DepKinds and the implementation could be done almost mechanically. We should try to move the implementation into define_maps! or define_dep_nodes!.
@michaelwoerister michaelwoerister added A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Oct 4, 2017
@cjgillot
Copy link
Contributor

cjgillot commented May 6, 2020

This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas-schievink @cjgillot @michaelwoerister