-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR borrowck: errors unreported in unreachable arms of match expressions #45043
Labels
A-borrow-checker
Area: The borrow checker
Comments
arielb1
changed the title
MIR borrowck: errors unreported in unreachable arms of match expressions
binding-less matches on borrowed data are incorrectly allowed
Oct 5, 2017
arielb1
added
A-borrow-checker
Area: The borrow checker
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
labels
Oct 5, 2017
arielb1
changed the title
binding-less matches on borrowed data are incorrectly allowed
MIR borrowck: errors unreported in unreachable arms of match expressions
Oct 5, 2017
arielb1
removed
the
I-unsound
Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness
label
Oct 5, 2017
my idea of fix mikhail-m1@ff15f84, it works but doesn't finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note from @pnkfelix for people looking at this bug: See important soundness issue in ariel's issue.
In the following code the borrow error in the
z
arm isn't reported with MIR borrowck, but it is reported with AST borrowck:(compile with
-Z emit-end-regions -Z borrowck-mir
to use the MIR borrowck)The text was updated successfully, but these errors were encountered: