Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "fail EXPR" for convenience #454

Closed
pcwalton opened this issue Jun 8, 2011 · 2 comments
Closed

Implement "fail EXPR" for convenience #454

pcwalton opened this issue Jun 8, 2011 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Jun 8, 2011

log_err "Going down in flames..."; fail;" code is very common. It'd be nice to able to optionally supply an error message with fail statements.
@lkuper
Copy link
Contributor

lkuper commented Jun 8, 2011

I've been trying to replace log_err "Going down in flames..."; fail; wherever it appears in the compiler with calls to cx.sess.err (or .unimpl or .bug or .span_err, whatever's appropriate), all of which have a fail. But fail that takes an optional error string would be good for user code.

@pcwalton
Copy link
Contributor Author

pcwalton commented Jun 8, 2011

Fixed in 42ac269, awesome!

@pcwalton pcwalton closed this as completed Jun 8, 2011
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@matthewjasper
Merge pull request rust-lang#454 from ehuss/split-types
5aafa12 
Split Types Chapter
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Speed up typetree operator[] (rust-lang#454)
1b1cc19 
* Speed up typetree operator[]

* Fix tests

* Speed up set and purge

* Speed up insert

* Remove extra clobber check
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this issue Mar 1, 2024
@antoyo
Merge pull request rust-lang#454 from rust-lang/update/gcc
2262073 
Update gcc version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcwalton @lkuper