Assertion failure causes wrong exit status

[alexcrichton]

fn main() {
  os::args();
  assert!(false);
}

Causes the program to return with exit status 0. Thankfully removing os::args() makes it return with nonzero, but it appears that at any point after the invocation of os::args() an assertion failure will cause an exit status of 0.

I ran this against a compiler built at e51ec26

[alexcrichton]

I don't know of the implications, but removing the else from this line (so both if blocks are always evaluated) seems to fix at least my problem. I don't know how much else it breaks, though.

[brson]

Previous pull request with discussion of solutions #5054

[nikomatsakis]

Not critical for 0.6; removing milestone

[alexcrichton]

I'm happy to say that with RUST_NEWRT=1 this failure does not occur. Seeing how we're probably going to be switching over to the new runtime in the near future, I'm going to close this issue.

Otherwise it'd just stay open until then because it doesn't look like it's going to be fixed in the meantime.

[alexcrichton]

Reopening, this should have a test.

[alexcrichton]

Closed in #7923