assertion failed: !are_upstream_rust_objects_already_included(sess) when building rustc_private with monolithic lto #45689
Labels
C-bug
Category: This is a bug.
E-needs-test
Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
kennytm
added
C-bug
|
Alright, the reproduce was shorter than I expected: cargo new --bin crashtest
cd crashtest
echo "
[profile.release]
lto = true
" >> Cargo.tomlmake src/main.rs this: #![feature(rustc_private)]
extern crate rustc_errors as errors;
fn main() { println!("Hello, world!"); }then |
|
For convenience I made this a repo: https://github.com/matthiaskrgr/rustc_crashtest_lto (run cargo build --release on this) |
|
Still crashing with |
Closed
|
Had a look at this again. This is the code causing the assert // Same thing as above, but for dynamic crates instead of static crates.
fn add_dynamic_crate(cmd: &mut Linker, sess: &Session, cratepath: &Path) {
// If we're performing LTO, then it should have been previously required
// that all upstream rust dependencies were available in an rlib format.
assert!(!is_full_lto_enabled(sess));
// Just need to tell the linker about where the library lives and
// what its name is
let parent = cratepath.parent();
if let Some(dir) = parent {
cmd.include_path(&fix_windows_verbatim_for_gcc(dir));
}
let filestem = cratepath.file_stem().unwrap().to_str().unwrap();
cmd.link_rust_dylib(&unlib(&sess.target, filestem),
parent.unwrap_or(Path::new("")));
}The problem might be that by trying to import parts of rustc it is required that we have these parts of rustc compiled as rlib and prepared for the lto which however might not be the case. |
|
rustc_private tracking issue: #27812 |
|
The ICE is still happening but the backtrace and assert message slightly changed |
matthiaskrgr
changed the title
|
@matthiaskrgr Does this still reproduce on a current nightly? |
|
The minimal example works. |
Centril
added
the
T-compiler
|
Ok, should we add a test perhaps? |
|
Yeah, definitely, I'll have a look. :) |
matthiaskrgr
added
the
E-needs-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EDIT: repo for reproducing: https://github.com/matthiaskrgr/rustc_crashtest_lto , run cargo build --release
crashes rustc:
The text was updated successfully, but these errors were encountered: