Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoctest: --nocapture still hides the output for successful tests #45724

Closed
QuietMisdreavus opened this issue Nov 2, 2017 · 1 comment · Fixed by #86230
Closed

rustdoctest: --nocapture still hides the output for successful tests #45724

QuietMisdreavus opened this issue Nov 2, 2017 · 1 comment · Fixed by #86230
Labels
A-doctests Area: Documentation tests, run by rustdoc C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@QuietMisdreavus
Copy link
Member

image

This is from my crate synchronoise. In this case, tests::signal_doctest and the doctest for SignalEvent are the same code - i needed to copy the doctest into a regular unit test to see the output.
@QuietMisdreavus QuietMisdreavus added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Nov 2, 2017
@woshilapin
Copy link
Contributor

Looks like a duplicate of #26309.

@jyn514 jyn514 added the A-doctests Area: Documentation tests, run by rustdoc label Nov 4, 2020
@camelid camelid mentioned this issue Jul 3, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 17, 2021
@GuillaumeGomez
Rollup merge of rust-lang#86230 - GuillaumeGomez:nocapture, r=camelid
6ca154d 
Add --nocapture option to rustdoc

Fixes rust-lang#26309.
Fixes rust-lang#45724.

Once this PR is merged, I'll send a PR to cargo to also pass `--nocapture` to rustdoc.

cc `@jyn514`
r? `@camelid`
@bors bors closed this as completed in 0fce468 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-doctests Area: Documentation tests, run by rustdoc C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --nocapture option to rustdoc GuillaumeGomez/rust
3 participants
@woshilapin @QuietMisdreavus @jyn514