Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLL: handle outlives relations, process region obligations in the MIR type checker #45826

Closed
nikomatsakis opened this issue Nov 7, 2017 · 2 comments
Closed

NLL: handle outlives relations, process region obligations in the MIR type checker #45826

nikomatsakis opened this issue Nov 7, 2017 · 2 comments
Assignees
@nikomatsakis
Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
NLL prototype

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 7, 2017 •
edited
Loading

Once #45825 lands, the NLL region solver will be integrated with the MIR type-checker and the rest of our inference infrastructure. However, we do not yet handle "verifys", which is the way that we sometimes encode type_outlives relations. Also, the MIR type checker is not currently invoking process_region_obligations, so outlives relations often do not even get processed.

Right now, you can't actually observe failures as a result of this, or at least I couldn't, I think because of various things that are not currently enforced by the MIR type-checker. But I am filing this bug as a placeholder for now. Mentoring instructions to come.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-compiler-nll labels Nov 7, 2017
@nikomatsakis nikomatsakis changed the title NLL: handle outlives relations NLL: handle outlives relations, process region obligations in the MIR type checker Nov 7, 2017
@nikomatsakis nikomatsakis mentioned this issue Nov 7, 2017
Closed
23 tasks
@TimNN TimNN added the C-bug Category: This is a bug. label Nov 7, 2017
@arielb1 arielb1 added this to the NLL prototype milestone Nov 15, 2017
@nikomatsakis nikomatsakis self-assigned this Nov 16, 2017
@nikomatsakis
Copy link
Contributor Author

I'm working on this.

@nikomatsakis nikomatsakis mentioned this issue Dec 6, 2017
Merged
@nikomatsakis
Copy link
Contributor Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
NLL prototype
Development

No branches or pull requests
3 participants
@nikomatsakis @TimNN @arielb1