Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/doc/cargo is almost empty #46195

Closed
behnam opened this issue Nov 22, 2017 · 7 comments
Closed

target/doc/cargo is almost empty #46195

behnam opened this issue Nov 22, 2017 · 7 comments
Assignees
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@behnam
Copy link
Contributor

behnam commented Nov 22, 2017

We started shipping cargo docs in #45692, but looks like a problem with the build system is resulting in mdbook generating an empty book, instead of using the source files.

The nightly output is here: https://doc.rust-lang.org/nightly/cargo/

@behnam
Copy link
Contributor Author

behnam commented Nov 22, 2017

/cc @steveklabnik, @alexcrichton

@behnam
Copy link
Contributor Author

behnam commented Nov 22, 2017

By the way, would be great to backport the fix to beta, as that one is also broken: https://doc.rust-lang.org/beta/cargo/

@kennytm kennytm added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 22, 2017
@steveklabnik
Copy link
Member

Ugh, I triple checked this when doing the PR in the first place. I wonder if anything else has changed with the build....

@steveklabnik
Copy link
Member

Okay so, I just built from scratch and it's absolutely generating the right files. So maybe this is an issue with the infra? Something not getting copied over to doc.rust-lang.org?

@rust-lang/infra

@kennytm kennytm removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 23, 2017
@alexcrichton
Copy link
Member

@steveklabnik how'd you build the book? Was it maybe not included in the default ./x.py doc?

@steveklabnik
Copy link
Member

steveklabnik commented Nov 29, 2017

I... lost it in my shell history, dang. I am pretty sure I did python x.py doc --stage=1. I can try again.

@steveklabnik
Copy link
Member

steveklabnik commented Nov 29, 2017

> rm -r -Fo .\build\x86_64-pc-windows-msvc\doc\
> python x.py doc --stage=1
<snip>
Cargo Book (x86_64-pc-windows-msvc) - cargo
Build completed successfully in 0:34:40
> ls .\build\x86_64-pc-windows-msvc\doc\cargo\getting-started\


    Directory: C:\Users\steve\src\rs\build\x86_64-pc-windows-msvc\doc\cargo\getting-started


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       11/29/2017   4:53 PM           9364 first-steps.html
-a----       11/29/2017   4:53 PM           7695 index.html
-a----       11/29/2017   4:53 PM           9683 installation.html

So, yep.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 29, 2017
The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this issue Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this issue Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this issue Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
arielb1 pushed a commit to arielb1/rust that referenced this issue Nov 30, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
kennytm added a commit to kennytm/rust that referenced this issue Dec 1, 2017
…-Simulacrum

rustbuild: Fix a typo with the Cargo book

The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
steveklabnik pushed a commit to steveklabnik/rust that referenced this issue Dec 14, 2017
The usage of `Path::new` prevented out-of-tree builds (like the bots do) from
working by accident!

Closes rust-lang#46195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants