src/test/compile-fail should have more files in subdirectories #46841
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
pnkfelix
added
T-compiler
technicalguy
added a commit
to technicalguy/rust
that referenced
this issue
Dec 21, 2017
Addresses issue rust-lang#46841. Created the following subdirectories: associated-item closures coherence const diagnostics issues lint macro regions traits typing variance Additionally rename some tests: renamed: unboxed-closer-non-implicit-copyable.rs -> closures/unboxed-closure-non-implicit-copyable.rs renamed: issue32829.rs -> issues/issue-32829-1.rs renamed: isssue-38821.rs -> issues/issue-38821.rs
Pulkit07
added a commit
to Pulkit07/rust
that referenced
this issue
Jan 19, 2018
…#46841 This patch moves the E0nnn files from src/test/compile-fail to a new subdirectory named diagnostics/. This is a part of issue rust-lang#46841
|
Update: It was decided that a proper set of guidelines were needed for directories (and test names) first, before moving anything around. |
XAMPPRocky
added
the
C-cleanup
|
Should this issue be closed ? Is there any work to be done ? |
|
@TheSirC: as far as I'm aware, #46841 (comment) is still relevant; it's just that no-one's got around to it yet. |
|
I think that is still the case. I certainly haven't got around to it (or anything). I think it would be good for someone with a bit more experience than me to suggest some guidelines and then we can work from there... |
|
Thank you guys for your answer! I will wait for guidelines so. |
davidtwco
added a commit
to davidtwco/rust
that referenced
this issue
Aug 10, 2018
bors
added a commit
that referenced
this issue
Aug 10, 2018
Move `compile-fail` tests to `ui` Fixes #46841, #52531, #44844. r? @nikomatsakis
davidtwco
added a commit
to davidtwco/rust
that referenced
this issue
Aug 13, 2018
bors
added a commit
that referenced
this issue
Aug 13, 2018
Move `compile-fail` tests to `ui` Fixes #46841, #52531, #44844. r? @nikomatsakis
davidtwco
added a commit
to davidtwco/rust
that referenced
this issue
Aug 14, 2018
bors
added a commit
that referenced
this issue
Aug 14, 2018
Move `compile-fail` tests to `ui` Fixes #46841, #52531, #44844. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Github refuses to list more than 1,000 files in a given directory listing.
As of this writing, its web interface reports that 1,260 entries are omitted from the printout for https://github.com/rust-lang/rust/tree/master/src/test/compile-fail
This has a simple fix: More subdirectories.
In particular, many of the tests even have a prefix that strongly implies a potential subdirectory to move that subset into; e.g. the associated-{const,item,type} tests could all go into
associated-item/. LIkewise, theE0nnntest could all go intodiagnostics/...(This is a super easy change to make to the test suite, though I know that some people want to separately migrate more/all of the tests into the
ui/subdirectory. I no longer object to the latter migration, but we'll still need to resolve this problem even when we do that migration.)The text was updated successfully, but these errors were encountered: