Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Conflicting representation hints" warning doesn't fire if there are multiple #[repr] attrs #47094

Closed
hanna-kruppe opened this issue Dec 31, 2017 · 0 comments · Fixed by #47111
Closed

"Conflicting representation hints" warning doesn't fire if there are multiple #[repr] attrs #47094

hanna-kruppe opened this issue Dec 31, 2017 · 0 comments · Fixed by #47111
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.

Comments

@hanna-kruppe
Copy link
Contributor

This produces the warning:

#[repr(C,u8)]
enum Foo { A, B }

This doesn't:

#[repr(C)]
#[repr(u8)]
enum Foo { A, B }
@kennytm kennytm added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. labels Dec 31, 2017
@hanna-kruppe hanna-kruppe mentioned this issue Jan 1, 2018
Open
hanna-kruppe pushed a commit to hanna-kruppe/rust that referenced this issue Jan 1, 2018
Check all repr hints together when checking for mis-applied attributes
0393611 
Fixes rust-lang#47094

Besides fixing that bug, this change has a user-visible effect on the spans in the "incompatible repr hints" warning and another error: they now point at `foo` and/or `bar` in `repr(foo, bar)` instead of the whole attribute. This is sometimes more precise (e.g., `#[repr(C, packed)]` on an enum points at the `packed`) but sometimes not. I moved a compile-fail test to a ui test to illustrate how it now looks in the common case of only one attribute.
@hanna-kruppe hanna-kruppe mentioned this issue Jan 1, 2018
Merged
bors added a commit that referenced this issue Jan 2, 2018
@bors
Auto merge of #47111 - rkruppe:repr-transparent, r=estebank
5873a74 
Check all repr hints together when checking for mis-applied attributes

Fixes #47094

Besides fixing that bug, this change has a user-visible effect on the spans in the "incompatible repr hints" warning and another error: they now point at `foo` and/or `bar` in `repr(foo, bar)` instead of the whole attribute. This is sometimes more precise (e.g., `#[repr(C, packed)]` on an enum points at the `packed`) but sometimes not. I moved a compile-fail test to a ui test to illustrate how it now looks in the common case of only one attribute.
@hanna-kruppe hanna-kruppe mentioned this issue Aug 10, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check all repr hints together when checking for mis-applied attributes hanna-kruppe/rust
2 participants
@kennytm @hanna-kruppe