-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
This doesn't look right -- both sides of the comparison use self.0.lo()
.
Lines 248 to 252 in 0f4ebf9
pub fn join(&self, other: Span) -> Option<Span> { | |
let self_loc = __internal::lookup_char_pos(self.0.lo()); | |
let other_loc = __internal::lookup_char_pos(self.0.lo()); | |
if self_loc.file.name != other_loc.file.name { return None } |
Mentioning @abonander, mentioning #38356
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.