Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispositioned help span indicator when emojis are involved #47380

Closed
est31 opened this issue Jan 12, 2018 · 1 comment
Closed

Mispositioned help span indicator when emojis are involved #47380

est31 opened this issue Jan 12, 2018 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@est31
Copy link
Member

est31 commented Jan 12, 2018

While issue #8706 is fixed now in most places, I have found a case where the error indicator is still mispositioned:

    let b = "hello";
    println!("🦀🦀🦀🦀🦀"); let _a = b + ", World!";

gives a mispositioned span:

  |
3 |     println!("🦀🦀🦀🦀🦀"); let _a = b.to_owned() + ", World!";
  |                                 ^^^^^^^^^^^^

on rust stable (1.23.0) as well as beta (1.24.0-beta.2) and nightly (73ac5d6 2018-01-11).

It should underline the b.to_owned().

I believe that this issue has the same root cause as #47377.

@est31
Copy link
Member Author

est31 commented Jan 17, 2018

#47407 fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Development

No branches or pull requests

2 participants