Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly regression for E0619 #47451

Closed
Keats opened this issue Jan 15, 2018 · 2 comments
Closed

Nightly regression for E0619 #47451

Keats opened this issue Jan 15, 2018 · 2 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Keats
Copy link

Keats commented Jan 15, 2018

This appeared in Travis (stable and beta still work)

$ rustc --version
rustc 1.25.0-nightly (3f92e8d89 2018-01-14)

The error:

error[E0619]: the type of this value must be known in this context
  --> components/content/src/file_info.rs:11:42
   |
11 |         let component = section.as_ref().to_string_lossy();
   |                                          ^^^^^^^^^^^^^^^

Link to Travis: https://travis-ci.org/Keats/gutenberg/builds/328770657?utm_source=github_status&utm_medium=notification

It does compile fine with rustc 1.25.0-nightly (b5392f545 2018-01-08) but I sadly can't download other nightlies atm to pin it down.

@Mark-Simulacrum Mark-Simulacrum added I-nominated regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2018
@Mark-Simulacrum Mark-Simulacrum added this to the 1.25 milestone Jan 15, 2018
@ExpHP
Copy link
Contributor

ExpHP commented Jan 15, 2018

Probably due to #46985 ?

(section is a Component, and <Component as AsRef<_>> is no longer unique)

@sfackler sfackler added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2018
@alexcrichton
Copy link
Member

The libs team discussed this issue today and concluded that we're going to close this. @Keats if you have difficulty updating though please let us know!

We're hoping we can head off errors like this in the future with #36443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants