-
Notifications
You must be signed in to change notification settings - Fork 13.3k
treemap's lazy iterator needs to be optimized #4763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Strictly speaking multiple lifetime parameters are not required to use a more traditional iterator. However, the current handling of the The key point is that the
Note: I changed the iterator protocol here to use a bool return on
|
5283a8b reworks the TreeMap lazy iterator to use `&mut` again, which closes #4763. It gets the performance of the set methods back in the same ballpark that it was pre-INHTWAMA which is nice. These can be turned back into methods eventually. e5b6334 removes the transitional smallintmap attributes which closes #4737.
Going back to the old way isn't currently possible (without multiple lifetime parameters), but it's currently doing implicit copies of the pointer stack with every iteration which should be fixable.
The text was updated successfully, but these errors were encountered: