Skip to content

Building from rustc-beta-src.tar.xz fails on git commands #47754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cuviper opened this issue Jan 25, 2018 · 2 comments
Closed

Building from rustc-beta-src.tar.xz fails on git commands #47754

cuviper opened this issue Jan 25, 2018 · 2 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Jan 25, 2018

I'm trying to test Fedora builds of the current beta:

$ cat rustc-beta-src/version
1.24.0-beta.8 (ed9751a90 2018-01-23)

Rustbuild fails in Build::beta_prerelease_version():

failed to execute command: "git" "ls-remote" "origin" "beta"
error: No such file or directory (os error 2)

With network access, git ls-remote could work with a URL instead of the missing origin remote. However, the configuration we use for rpm builds is completely offline. (Actually, I probably don't even have git in the build root at the moment, but I could add that.)

A few options:

  • Just don't support --release-channel=beta with non-git sources. (status quo)
  • If git fails, call the release X.Y.Z-beta without a prerelease version at all.
  • Try to extract the prerelease version from the same version file I quoted above.
  • Allow an environment variable or config option to set a prerelease version manually.
@kennytm kennytm added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Jan 25, 2018
@kennytm
Copy link
Member

kennytm commented Jan 25, 2018

cc @alexcrichton

@alexcrichton
Copy link
Member

Oops, sorry about that! I think even if we had a url it'd fail later because it wants to find the diff between the origin's branches and the local revision, but with the tarballs there's no local revision!

I'd say we should just drop the prerelease number entirely from betas-build-from-tarballs perhaps? Having an optional env var override seems fine by me though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants