Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Debug implementations for primitive types as #[inline] #47792

Closed
bholley opened this issue Jan 27, 2018 · 1 comment
Closed

Mark Debug implementations for primitive types as #[inline] #47792

bholley opened this issue Jan 27, 2018 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@bholley
Copy link
Contributor

bholley commented Jan 27, 2018

This should allow them to forward directly to the Display implementations without generating adapters.

See #47785 (comment)
@cuviper cuviper added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jan 27, 2018
@dtolnay dtolnay changed the title Mark derived Debug implementations for primitive types as #[inline] Mark Debug implementations for primitive types as #[inline] Jan 27, 2018
@dtolnay dtolnay added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jan 27, 2018
@ghost
Copy link

ghost commented Jan 27, 2018

Hey, I'd like to take this. Should I just put an #[inline] before each fmt function of the Debug impls for primitives?

@ghost ghost mentioned this issue Jan 29, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jan 31, 2018
@kennytm
Rollup merge of rust-lang#47840 - penpalperson:master, r=bluss
0370717 
Marked Debug implementations for primitive types as #[inline]

Change for issue rust-lang#47792.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuviper @bholley @dtolnay