-
Notifications
You must be signed in to change notification settings - Fork 13.4k
The standard libary documentation renders some links as red, they feel like missing pages to me #47801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We certainly can change the colour to something else. |
Fixing this would involve changing this class (and the equivalent for the dark theme css) to some other colour. |
@nagisa I would like to take that up. Any suggestion what color I should use for both themes? |
I’ve no opinions on the colour, other than that it should be distinct enough from the colours used for the other kinds of items. |
the color has always looked orange to me, perhaps make it slightly lighter? |
Changing the team from dev-tools/rustdoc to docs. This is more about a stylistic decision of the documentation. |
fwiw, I picked up Rust ~2 months ago and initially had the same thought when reading Rust documentation with lots of red links |
…labnik Changed color of struct link from #ff794d to #2dbfb8 for Rust docs This is in reference to rust-lang#47801 here I have changed the default color of struct link for `#ff794d` to `#2dbfb8` cc: @nagisa @timClicks
That orange does look nice to me though. But the more confusing parts to me is that some clickable parts are black (it takes me some time to figure out how to go to other crates doc or previous level of crates doc without pressing the previous tab button in browser). As reference: https://doc.rust-lang.org/std/ops/struct.Range.html
|
I believe this was fixed by #47806 |
In the interests of improving the on-boarding experience for newcomers to Rust, I thought it would be worthwhile to share a personal anecdote of something that was a snag for my own learning.
Apparently I've been trained by Wikipedia/MediaWiki defaults to see red links and think they mean missing page. It took me an embarrassingly long time to realize that struct definitions are perfectly clickable. So for several months while learning Rust I eagerly waited for Rust's docs to be updated with info about their struct definitions.
I have no idea if this is a widespread phenomenon, but remarkably the cognitive dissonance still lingers. I'm also not certain if this warrants filing an issue. Feel free to mark as wontfix :)
The text was updated successfully, but these errors were encountered: