Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenTree::kind naming #48188

Closed
dtolnay opened this issue Feb 13, 2018 · 1 comment
Closed

TokenTree::kind naming #48188

dtolnay opened this issue Feb 13, 2018 · 1 comment
Assignees
Labels
A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@dtolnay
Copy link
Member

dtolnay commented Feb 13, 2018

The naming of TokenTree::kind is confusing. I would expect either kind: TokenKind or node: TokenNode, not kind: TokenNode.

@dtolnay dtolnay added the A-macros-2.0 Area: Declarative macros 2.0 (#39412) label Feb 13, 2018
@dtolnay dtolnay self-assigned this Feb 13, 2018
@TimNN TimNN added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Feb 13, 2018
@dtolnay
Copy link
Member Author

dtolnay commented Apr 29, 2018

Fixed in #49597.

@dtolnay dtolnay closed this as completed Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

2 participants