Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component AsRef change causes beta regression #48716

Closed
Mark-Simulacrum opened this issue Mar 4, 2018 · 7 comments
Closed

Component AsRef change causes beta regression #48716

Mark-Simulacrum opened this issue Mar 4, 2018 · 7 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 4, 2018

This is probably going to be closed as expected breakage. This means those cc-ed below should probably aim to fix their crate and release a new point release.

#46985 added an impl of AsRef<Path> for Component which causes these crates to stop compiling:

Estimated ecosystem breakage: 143 versions (0.18% of versions published), 39 crates (0.27% of crates).

cc @rust-lang/libs

@PlasmaPower
Copy link
Contributor

Unfortunately app_dirs is no longer maintained, with no good replacement that I can find.

@alexcrichton alexcrichton added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 5, 2018
@vitiral
Copy link
Contributor

vitiral commented Mar 6, 2018

For crates that are no longer maintained what is the right course of action here? For instance rst_app is just the previous name of artifact_app so I have no intention of fixing it. Should I yank it?

@carols10cents
Copy link
Member

@vitiral You could put maintenance = { status = "deprecated" } in the Cargo.toml of rst_app, and possibly mention that it was renamed to artifact_app in rst_app's description.

@alexcrichton
Copy link
Member

This was discussed during the libs triage meeting recently and we decided that we're not going to revert this, but if any crates need assistance updating we're more than happy to help!

@alexcrichton
Copy link
Member

Closing due to previous comment

@PlasmaPower
Copy link
Contributor

PlasmaPower commented Mar 22, 2018

For anyone looking for a replacement for app_dirs, try app_dirs2 or directories.

@pravic
Copy link
Contributor

pravic commented Mar 30, 2018

#46985 is in relnotes, but this issue wasn't mentioned at all despite of the compatibility breakage (not to mention promised compatability guaranties).

cc @steveklabnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants