Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for LLVM align attributes (-Z arg_align_attributes) #49185

Closed
scottmcm opened this issue Mar 19, 2018 · 1 comment
Closed

Tracking issue for LLVM align attributes (-Z arg_align_attributes) #49185

scottmcm opened this issue Mar 19, 2018 · 1 comment
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@scottmcm
Copy link
Member

In theory we should be emitting LLVM align <n> attributes (https://llvm.org/docs/LangRef.html#attr-align) for references, since they're always aligned.

However, it turns out that these get inlined as assume calls, which (per the HACK comment in the code) block other optimizations, so they're currently disabled.

-Z flag was added in #49122
@scottmcm scottmcm mentioned this issue Mar 19, 2018
Merged
@sanxiyn sanxiyn added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Mar 20, 2018
@nikic nikic added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 20, 2018
@jonas-schievink jonas-schievink added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-codegen Area: Code generation C-enhancement Category: An issue proposing an enhancement or a PR with one. I-slow Issue: Problems and improvements with respect to performance of generated code. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Nov 26, 2019
@nikic
Copy link
Contributor

nikic commented Mar 26, 2020

This flag has already been removed quite a while ago in #57021, so closing this.

@nikic nikic closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sanxiyn @nikic @jonas-schievink @scottmcm