Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle namespaces in a more generic way in resolve::resolve_single_import #4949

Closed
catamorphism opened this issue Feb 15, 2013 · 3 comments
Closed

Handle namespaces in a more generic way in resolve::resolve_single_import #4949

catamorphism opened this issue Feb 15, 2013 · 3 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

as per FIXME (formerly XXX)
@emberian
Copy link
Member

emberian commented Jul 7, 2013

Still relevant

@catamorphism
Copy link
Contributor Author

I'm going to vote for not making this change, actually; it seems like premature abstraction. I'll remove the FIXME and check in later today, but if anyone has a strong opinion, they can register it in the meantime.

@emberian
Copy link
Member

I looked at it, and it didn't seem like there was a clean or easy way to make the change.

catamorphism added a commit to catamorphism/rust that referenced this issue Aug 22, 2013
@catamorphism
rustc: Remove FIXME (see rust-lang#4949)
120c550
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#4993 - rust-lang:doc-unsafe-macro-check, r=fl…
a0fdca5 
…ip1995

External macro check for missing_*_doc

This fixes rust-lang#4949

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @emberian