New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine whether we need a node ID when resolving methods #4951

Closed

catamorphism opened this issue Feb 15, 2013 · 4 comments

Labels

A-resolve C-cleanup

Contributor

catamorphism commented Feb 15, 2013

See FIXME (formerly XXX) in the item_trait case in resolve::resolve_item.

The text was updated successfully, but these errors were encountered:

Contributor

msullivan commented Jul 1, 2013

FIXME still there. We probably don't need a node_id, if it actually works...

Member

emberian commented Aug 19, 2013

Member

huonw commented Nov 10, 2013

Triage: FIXME is still there. I guess having a NodeId would make other tooling easier, e.g. #8961 would likely be easier to fix if every method had an associated NodeId (since it would then not require (as much) special casing).

Member

steveklabnik commented Aug 12, 2014

For future spelunkers, this is talking about

rust/src/librustc/middle/resolve.rs

Line 3724 in e2273d9

// FIXME #4951: Do we need a node ID here?

sanxiyn mentioned this issue

Remove a FIXME #26889

Merged

steveklabnik added a commit to steveklabnik/rust that referenced this issue


          Rollup merge of rust-lang#26889 - sanxiyn:fixme, r=alexcrichton

80f9d93

Fix rust-lang#4951.

bors closed this as completed in #26889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment