Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry::and_modify should use FnOnce #49581

Closed
Zoxc opened this issue Apr 2, 2018 · 3 comments
Closed

Entry::and_modify should use FnOnce #49581

Zoxc opened this issue Apr 2, 2018 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone
1.26

Comments

@Zoxc
Copy link
Contributor

Zoxc commented Apr 2, 2018

This should change to use FnOnce instead of FnMut before it lands on stable.
https://doc.rust-lang.org/std/collections/hash_map/enum.Entry.html#method.and_modify

cc @rust-lang/libs
@Zoxc Zoxc added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2018
@alexcrichton alexcrichton added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 2, 2018
@alexcrichton
Copy link
Member

Labelling as a regression to ensure we keep track of this, although it's not technically a regression

@alexcrichton alexcrichton added this to the 1.26 milestone Apr 2, 2018
@alexcrichton alexcrichton mentioned this issue Apr 19, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 19, 2018
@alexcrichton
Tweak some stabilizations in libstd
ca79ba3 
This commit tweaks a few stable APIs in the `beta` branch before they hit
stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were
deleted (added in rust-lang#49381, issue at rust-lang#49657). The `and_modify` APIs added
in rust-lang#44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure.

Closes rust-lang#49581
Closes rust-lang#49657
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 19, 2018
@alexcrichton
[beta] Tweak some stabilizations in libstd
222ca2d 
This commit tweaks a few stable APIs in the `beta` branch before they hit
stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were
deleted (added in rust-lang#49381, issue at rust-lang#49657). The `and_modify` APIs added
in rust-lang#44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure.

Closes rust-lang#49581
Closes rust-lang#49657
bors added a commit that referenced this issue Apr 20, 2018
@bors
Auto merge of #50088 - alexcrichton:std-tweaks, r=sfackler
a10bb6b 
Tweak some stabilizations in libstd

This commit tweaks a few stable APIs in the `beta` branch before they hit
stable. The `str::is_whitespace` and `str::is_alphanumeric` functions were
deleted (added in #49381, issue at #49657). The `and_modify` APIs added
in #44734 were altered to take a `FnOnce` closure rather than a `FnMut` closure.

Closes #49581
Closes #49657
@KamilaBorowska
Copy link
Contributor

Now that this is fixed, should it be marked as regression-from-stable-to-beta. It's technically not a regression, it's was marked as such for tracking purposes.

@alexcrichton
Copy link
Member

Ah that tag is primarily used for open issue, once closed the tags on an issue are anyone's guess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.26
Development

No branches or pull requests
3 participants
@Zoxc @alexcrichton @KamilaBorowska