Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: check_no_compiler_crash doesn't catch non-ICE panics #49888

Closed
cuviper opened this issue Apr 11, 2018 · 0 comments
Closed

compiletest: check_no_compiler_crash doesn't catch non-ICE panics #49888

cuviper opened this issue Apr 11, 2018 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Apr 11, 2018

As noted in #49826 (comment), currently rustc is panicking on compile-fail/issue-36638 (which I will file as a separate bug), but compiletest does not detect this because it's also not caught as an ICE (to be fixed by #49826). In check_no_compiler_crash, it only looks for the literal string "error: internal compiler error".
@cuviper cuviper added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Apr 11, 2018
This was referenced Apr 11, 2018
Closed
Merged
@abonander abonander mentioned this issue Apr 20, 2018
Merged
bors added a commit that referenced this issue Apr 27, 2018
@bors
Auto merge of #49891 - cuviper:compiletest-crash, r=alexcrichton
9822b57 
compiletest: detect non-ICE compiler panics

Fixes #49888, but will be blocked by revealing #49889.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuviper