Put uv in its own crate #5019
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
Comments
|
Still relevant |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Oct 29, 2013
There are a few reasons that this is a desirable move to take: 1. Proof of concept that a third party event loop is possible 2. Clear separation of responsibility between rt::io and the uv-backend 3. Enforce in the future that the event loop is "pluggable" and replacable Here's a quick summary of the points of this pull request which make this possible: * Two new lang items were introduced: event_loop, and event_loop_factory. The idea of a "factory" is to define a function which can be called with no arguments and will return the new event loop as a trait object. This factory is emitted to the crate map when building an executable. The factory doesn't have to exist, and when it doesn't then an empty slot is in the crate map and a basic event loop with no I/O support is provided to the runtime. * When building an executable, then the rustuv crate will be linked by default (providing a default implementation of the event loop) via a similar method to injecting a dependency on libstd. This is currently the only location where the rustuv crate is ever linked. * There is a new #[no_uv] attribute (implied by #[no_std]) which denies implicitly linking to rustuv by default Closes rust-lang#5019
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
Normalize lint messages in cast_precision_loss Follow-up of rust-lang#5000 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For #4419 we want uv to be the default event loop implementation, but do not want to put it into core. Instead it will live in a
uvcrate with a dependency oncoreand implementing several types in core. When generating the crate entry point, rustc will passrust_starta pointer to a factory function that returns the uv loop.The text was updated successfully, but these errors were encountered: