Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc with a ?search=foo URL, stuck at "Loading search results..." #50283

Closed
SimonSapin opened this issue Apr 27, 2018 · 0 comments
Closed

rustdoc with a ?search=foo URL, stuck at "Loading search results..." #50283

SimonSapin opened this issue Apr 27, 2018 · 0 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@SimonSapin
Copy link
Contributor

Steps:

ReferenceError: ALIASES is not defined[Learn More] main.js:1016:1
	execQuery http://localhost/rust/main.js:1016:1
	execSearch http://localhost/rust/main.js:1319:31
	search http://localhost/rust/main.js:1404:25
	startSearch http://localhost/rust/main.js:1548:13
	initSearch http://localhost/rust/main.js:1552:9
	<anonymous> http://localhost/rust/search-index.js:8:1

Grepping shows that ALIASES is defined in aliases.js. This file is included with <script defer src="../aliases.js">. This defer is presumably problematic for the search-during-initial-load case.
@SimonSapin SimonSapin added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-docs-rustdoc labels Apr 27, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 27, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Apr 27, 2018
@kennytm
Rollup merge of rust-lang#50284 - GuillaumeGomez:search-load-failure,…
e598394 
… r=SimonSapin

fix search load page failure

Fixes rust-lang#50283.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SimonSapin