Skip to content

rustdoc/stdlib docs: Auto trait implementations are missing reference types. #50431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alercah opened this issue May 3, 2018 · 2 comments
Closed

rustdoc/stdlib docs: Auto trait implementations are missing reference types. #50431

alercah opened this issue May 3, 2018 · 2 comments
Assignees
@GuillaumeGomez
Labels
A-trait-system Area: Trait system C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@alercah
Copy link
Contributor

alercah commented May 3, 2018

The auto traits Sync and RefUnwindSafe do not indicate anywhere in generated documentation that they are generated for reference types. The RefUnwindSafe page appears to not have any auto implementations listed; Sync's page lists auto implementors but does not include references. The reference page covers it in the prose, but neither of the traits appears in the implementation list.
@ExpHP
Copy link
Contributor

ExpHP commented May 4, 2018 •
edited
Loading

I think it is not just references, but all primitive types; u8, (), [T], ...

Edit: Except the negative impls for *mut T and *const T, but those are explicitly in the source code of core.

@GuillaumeGomez GuillaumeGomez self-assigned this May 7, 2018
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 7, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue May 8, 2018
Merged
bors added a commit that referenced this issue May 18, 2018
@bors
Auto merge of #50533 - GuillaumeGomez:rustdoc-prim-auto, r=QuietMisdr…
ba64edb 
…eavus

add auto-impl for primitive type

Part of #50431.

I have no clue how to test this though with the rustdoc test suite...

r? @QuietMisdreavus
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-trait-system Area: Trait system labels Oct 2, 2018
@GuillaumeGomez
Copy link
Member

Fixed by #50533.

@fmease fmease added A-trait-system Area: Trait system and removed A-trait-system Area: Trait system labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-trait-system Area: Trait system C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ExpHP @GuillaumeGomez @XAMPPRocky @fmease @alercah