Skip to content

Adding #[inline] attribute causes error #50616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zoxc opened this issue May 10, 2018 · 4 comments
Closed

Adding #[inline] attribute causes error #50616

Zoxc opened this issue May 10, 2018 · 4 comments
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-linkage Area: linking into static, shared libraries and binaries C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Zoxc
Copy link
Contributor

Zoxc commented May 10, 2018

Adding #[inline] attributes to libsyntax_pos causes errors

Branch: https://github.com/Zoxc/rust/tree/inline-error

This might be due to LLVM bug. Perhaps this issue should be added to #50422?
@jonas-schievink
Copy link
Contributor

Pasting the error for convenience:

[01:26:47] ---- [run-pass] run-pass-fulldeps/macro-crate-multi-decorator-literals.rs stdout ----
[01:26:47] 	
[01:26:47] error: compilation failed!
[01:26:47] status: exit code: 101
[01:26:47] command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "--target=i686-unknown-linux-gnu" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "-Crpath" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux"
[01:26:47] stdout:
[01:26:47] ------------------------------------------
[01:26:47] 
[01:26:47] ------------------------------------------
[01:26:47] stderr:
[01:26:47] ------------------------------------------
[01:26:47] warning: unused `#[macro_use]` import
[01:26:47]   --> /checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs:17:1
[01:26:47]    |
[01:26:47] 17 | #[macro_use]
[01:26:47]    | ^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    = note: #[warn(unused_imports)] on by default
[01:26:47] 
[01:26:47] warning: compiler plugin used as an ordinary library
[01:26:47]   --> /checkout/src/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.rs:19:1
[01:26:47]    |
[01:26:47] 19 | extern crate macro_crate_test;
[01:26:47]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:26:47]    |
[01:26:47]    = note: #[warn(plugin_as_library)] on by default
[01:26:47] 
[01:26:47] error: linking with `cc` failed: exit code: 1
[01:26:47]   |
[01:26:47]   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m32" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals1.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals10.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals11.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals2.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals3.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals4.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals5.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals6.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals7.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals8.rcgu.o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals9.rcgu.o" "-o" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.stage2-i686-unknown-linux-gnu.aux" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_plugin-b095cdd51f2398b7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_metadata-5958a5d11a6d02b8" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_ext-d61f5115024df074" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc-bb9cdae09a478538" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "test-be30e492d9d17d99" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "term-79e6104dc4106b98" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "proc_macro-ab418923d4130811" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "graphviz-425b37f3eb107a9f" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "fmt_macros-ae1eb2a98770082e" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "arena-a11d08f45d8c6283" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax-5ef387d08892ffa7" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_target-434dc93720f9df82" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_errors-0798acec4bef62ae" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "syntax_pos-188bf7c100a2e31c" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_data_structures-fc5193a97cae01c4" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "rustc_cratesio_shim-5de3f5c2e9ed281d" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "serialize-b8b2d69c4870530f" "-Wl,--start-group" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-l" "std-bc9c5f91b6be96a0" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/libcompiler_builtins-e6756d75def20064.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" "-Wl,-rpath,$ORIGIN/../../stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,-rpath,/checkout/obj/lib/rustlib/i686-unknown-linux-gnu/lib" "-Wl,--enable-new-dtags"
[01:26:47]   = note: /checkout/obj/build/i686-unknown-linux-gnu/test/run-pass-fulldeps/macro-crate-multi-decorator-literals.macro_crate_multi_decorator_literals0.rcgu.o: In function `core::str::traits::_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$::eq::hd698c0257184e0d2':
[01:26:47]           macro_crate_multi_decorator_literals0-317d481089b8c8fe83113de504472633.rs:(.text._ZN4core3str6traits54_$LT$impl$u20$core..cmp..PartialEq$u20$for$u20$str$GT$2eq17hd698c0257184e0d2E+0x78): undefined reference to `core::cmp::impls::_$LT$impl$u20$core..cmp..PartialEq$LT$$RF$$u27$b$u20$B$GT$$u20$for$u20$$RF$$u27$a$u20$A$GT$::eq::h89a3cf1172f82e51'
[01:26:47]           collect2: error: ld returned 1 exit status
[01:26:47]           
[01:26:47] 
[01:26:47] error: aborting due to previous error

@Mark-Simulacrum
Copy link
Member

It would be good to narrow this down to fewer inline attributes probably.

@XAMPPRocky XAMPPRocky added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Oct 2, 2018
@jonas-schievink jonas-schievink added the A-linkage Area: linking into static, shared libraries and binaries label Apr 18, 2020
@bjorn3
Copy link
Member

bjorn3 commented Dec 17, 2021

Rustc plugins are deprecated, mostly gutted and will likely be removed entirely once servo doesn't use them anymore.

@workingjubilee
Copy link
Member

This was "fixed" like a cat (by removing plugins).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-linkage Area: linking into static, shared libraries and binaries C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Zoxc @jonas-schievink @XAMPPRocky @Mark-Simulacrum @bjorn3 @workingjubilee