Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-make wasm tests cannot be run #50711

Closed
ehuss opened this issue May 13, 2018 · 2 comments
Closed

run-make wasm tests cannot be run #50711

ehuss opened this issue May 13, 2018 · 2 comments

Comments

@ehuss
Copy link
Contributor

ehuss commented May 13, 2018

I am unable to run the wasm tests in src/test/run-make. It looks like the wasm32-unknown Travis image is no longer running them, either. Reverting some of the changes in #50000 brings them back (but causes the cross-lang-lto test to fail).

I'm not very familiar with the bootstrap code, so I'm uncertain how this should be fixed.

cc @alexcrichton @michaelwoerister

@alexcrichton
Copy link
Member

Oh oops, sorry I should have caught this in review!

I think the fix is:

  • Move cross-lang-lto from run-make to run-make-fulldeps
  • Change the RunMake test suite back to default_test! from its current host_test!

@ehuss or @michaelwoerister, would y'all be able to submit a PR with that?

@ehuss
Copy link
Contributor Author

ehuss commented May 15, 2018

I can give it a shot.

ehuss added a commit to ehuss/rust that referenced this issue May 15, 2018
kennytm added a commit to kennytm/rust that referenced this issue May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants