Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic, env, and vec macros missing from std API doc search results #51095

Closed
ashtneoi opened this issue May 26, 2018 · 2 comments
Closed

panic, env, and vec macros missing from std API doc search results #51095

ashtneoi opened this issue May 26, 2018 · 2 comments

Comments

@ashtneoi
Copy link
Contributor

ashtneoi commented May 26, 2018

On stable (1.26.0), if I open the standard library API docs in my browser and search for one of the three strings panic, env, or vec, the search results include both the module and the macro by that name. Note that the module and the macro have the same path (std::panic, etc.).

On nightly 2018-05-25, those three macros no longer appear in search results, though their corresponding modules do. The macros still show up in the std crate index's macro list (std/index.html#macros). Since the macros and the modules have matching paths, it sounds like the macros are being shadowed somehow.


$ rustc --version --verbose
rustc 1.28.0-nightly (990d8aa74 2018-05-25)
binary: rustc
commit-hash: 990d8aa743b1dda3cc0f68fe09524486261812c6
commit-date: 2018-05-25
host: x86_64-unknown-linux-gnu
release: 1.28.0-nightly
LLVM version: 6.0
@ollie27
Copy link
Member

ollie27 commented Jun 16, 2018

Looks like this was caused by #50259. We need to take into account the type when de-duplicating results not just the full path. cc. @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Oh indeed, I just fixed this issue for keywords so I'll fix it as well for macros.

bors added a commit that referenced this issue Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants