Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate stable-borrow-state regressed in 1.28 beta #51840

Closed
pietroalbini opened this issue Jun 27, 2018 · 2 comments
Closed

Crate stable-borrow-state regressed in 1.28 beta #51840

pietroalbini opened this issue Jun 27, 2018 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@pietroalbini
Copy link
Member

The test suite of the stable-borrow-state crate failed to run, and after a quick glance at the source code I think that's caused by a change in the RefCell behavior.

@pietroalbini pietroalbini added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Jun 27, 2018
@pietroalbini pietroalbini added this to the 1.28 milestone Jun 27, 2018
@tcr
Copy link

tcr commented Jun 27, 2018

This crate was intentionally used as a stopgap until I could rely on a nightly feature, and months later is fully unused. I'm going to yank it.

@pietroalbini pietroalbini added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 27, 2018
@Mark-Simulacrum
Copy link
Member

Regression caused by aec00f9 - #51466.

This is unsurprising as the library was transmuting to get at internal details. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants