Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for write_all_at/read_exact_at convenience methods #51984

Closed
drrlvn opened this issue Jul 2, 2018 · 9 comments · Fixed by #57625
Closed

Tracking issue for write_all_at/read_exact_at convenience methods #51984

drrlvn opened this issue Jul 2, 2018 · 9 comments · Fixed by #57625
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@drrlvn
Copy link
Contributor

drrlvn commented Jul 2, 2018

The Read and Write traits contain convenience methods read_exact and write_all wrapping read and write. This issue tracks addition of similar methods to std::os::unix::fs::FileExt trait's read_at and write_at.

This is implemented in #51809.
@drrlvn drrlvn mentioned this issue Jul 2, 2018
Merged
@alexcrichton alexcrichton added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Jul 2, 2018
@fbstj
Copy link
Contributor

fbstj commented Jul 16, 2018

if this is a tracking issue, maybe it should have the C-tracking-issue label

@tomaka
Copy link
Contributor

tomaka commented Dec 23, 2018

We should eventually add similar methods to std::os::windows::fs::FileExt.

@drrlvn
Copy link
Contributor Author

drrlvn commented Dec 31, 2018

@tomaka I know nothing about developing on Windows so I can't do it myself but I guess a PR would be accepted.

@alexcrichton Can we stabilize this? Is there anything that still needs to be done?

@alexcrichton
Copy link
Member

Seems reasonable to me!

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jan 2, 2019 •
edited by sfackler
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 2, 2019
@rfcbot
Copy link

rfcbot commented Jan 2, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 2, 2019
@rfcbot
Copy link

rfcbot commented Jan 12, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 12, 2019
@drrlvn
Copy link
Contributor Author

drrlvn commented Jan 14, 2019

What's the next step? Should I make a PR to stabilize? Sorry but I don't fully understand how things work yet.

@alexcrichton
Copy link
Member

@drrlvn indeed that should be all that's necessary! If you'd like to make the PR you're also more than welcome to do so!

@drrlvn drrlvn mentioned this issue Jan 15, 2019
Merged
bors added a commit that referenced this issue Jan 15, 2019
@bors
Auto merge of #57625 - drrlvn:patch-1, r=Centril
9201924 
Stabilize FileExt::read_exact_at/write_all_at

r? alexcrichton

Closes #51984.
@jonas-schievink jonas-schievink added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize FileExt::read_exact_at/write_all_at
6 participants
@fbstj @drrlvn @alexcrichton @tomaka @jonas-schievink @rfcbot