Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2018 edition lints #52047

Closed
11 of 15 tasks
nrc opened this issue Jul 4, 2018 · 1 comment
Closed
11 of 15 tasks

2018 edition lints #52047

nrc opened this issue Jul 4, 2018 · 1 comment
Labels
A-edition-2018-lints Area: Lints supporting the 2018 edition E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. WG-epoch Working group: Epoch (2018) management

Comments

@nrc
Copy link
Member

nrc commented Jul 4, 2018 •
edited by zackmdavis
Loading

Edition lints in the rust_2018_idioms group power Rustfix, the tool for transitioning crates from the 2015 to the 2018 edition. Having a good automatic tool for migrating crates is essential to a successful 2018 edition, and having well-implemented lints is essential to Rustfix actually working.

All issues

rust_2018_compatibility

rust_2018_idioms
@nrc nrc added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. E-needs-mentor WG-epoch Working group: Epoch (2018) management A-edition-2018-lints Area: Lints supporting the 2018 edition labels Jul 4, 2018
@zackmdavis zackmdavis mentioned this issue Aug 3, 2018
Merged
@alexcrichton
Copy link
Member

I believe that this issue is largely done now so I'm going to close this in favor of the tracking issues we have for specific lints now.

bors added a commit that referenced this issue Sep 29, 2018
@bors
Auto merge of #53013 - zackmdavis:infer_outlints, r=nikomatsakis
a0a6e43 
in which inferable outlives-requirements are linted

RFC 2093 (tracking issue #44493) lets us leave off these
commonsensically inferable `T: 'a` outlives requirements. (A separate
feature-gate was split off for the case of 'static lifetimes, for
which questions still remain.) Detecting these was requested as an
idioms-2018 lint.

Resolves #52042, an item under the fabulous metaïssue #52047.

It's plausible that this shouldn't land until after `infer_outlives_requirements` has been stabilized ([final comment period started](#44493 (comment)) 4 days ago), but I think there's also a strong case to not-wait in order to maximize the time that [Edition Preview 2](https://internals.rust-lang.org/t/rust-2018-release-schedule-and-extended-beta/8076) users have to kick at it. (It's allow by default, so there's no impact unless you explicitly turn it or the rust-2018-idioms group up to `warn` or higher.)

Questions—

 * Is `explicit-outlives-requirements` a good name? (I chose it as an [RFC 344](https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints)-compliant "inversion" of the feature-gate name, `infer_outlives_requirements`, but I could imagine someone arguing that the word `struct` should be part of the name somewhere, for specificity.)

 * Are there any false-positives or false-negatives? @nikomatsakis [said that](#52042 (comment)) getting this right would be "fairly hard", which makes me nervous that I'm missing something. The UI test in the initial submission of this pull request just exercises the examples [given in the Edition Guide](https://rust-lang-nursery.github.io/edition-guide/2018/transitioning/ownership-and-lifetimes/struct-inference.html).

![infer_outlints](https://user-images.githubusercontent.com/1076988/43625740-6bf43dca-96a3-11e8-9dcf-793ac83d424d.png)

r? @alexcrichton
@stepancheg stepancheg mentioned this issue Jul 31, 2019
Closed
@elpiel elpiel mentioned this issue Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-edition-2018-lints Area: Lints supporting the 2018 edition E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. WG-epoch Working group: Epoch (2018) management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @nrc