Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ptr.mut_offset method #5214

Closed
brson opened this issue Mar 3, 2013 · 1 comment
Closed

Add Ptr.mut_offset method #5214

brson opened this issue Mar 3, 2013 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
old 1.0 milestone

Comments

@brson
Copy link
Contributor

brson commented Mar 3, 2013

core::ptr contains a mut_offset function, but not the method.
@brson
Copy link
Contributor Author

brson commented Mar 6, 2013

*mut T has an offset method that returns a mutable pointer.

@brson brson closed this as completed Mar 6, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 20, 2020
@bors
Auto merge of rust-lang#6441 - ebroto:use_rustflags, r=flip1995
684f17e 
Pass Clippy args also trough RUSTFLAGS

This removes a hack (\_\_CLIPPY_HACKERY\_\_) to add another one :)

It allows this workflow to work:
```terminal
cargo clippy                             # warning: empty `loop {}` wastes CPU cycles
cargo clippy -- -A clippy::empty_loop    # no warnings emitted
```

Before this change the new flag was not taken into consideration in cargo's fingerprint and the warning was emitted again. I guess that ideally we could add a specific env var for compiler wrapper arguments, but in the meantime this should do the job.

changelog: Pass clippy arguments through RUSTFLAGS so that changing them will trigger a rebuild

r? `@flip1995`
cc `@ehuss` (I think this may count as another step towards stabilizing `RUSTC_WORKSPACE_WRAPPER` 😄)

Fixes rust-lang#5214 and avoids frustration for users unfamiliar with the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
1 participant
@brson