Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macro_rules expr matcher doesn't match async #52951

Closed
cramertj opened this issue Aug 1, 2018 · 1 comment
Closed

macro_rules expr matcher doesn't match async #52951

cramertj opened this issue Aug 1, 2018 · 1 comment
Labels
A-parser Area: The parsing of Rust source code to an AST. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@cramertj
Copy link
Member

cramertj commented Aug 1, 2018 •
edited
Loading 

macro_rules! match_expr {
    ($x:expr) => {}
}

fn main() {
    match_expr!(async {})
}

fails with "error: no rules expected the token async". Playground link
@cramertj cramertj mentioned this issue Aug 1, 2018
Merged
@petrochenkov
Copy link
Contributor

async needs to be added to fn ident_can_begin_expr in libsyntax.

@petrochenkov petrochenkov added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-parser Area: The parsing of Rust source code to an AST. labels Aug 1, 2018
@cramertj cramertj mentioned this issue Aug 1, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 1, 2018
@pietroalbini
Rollup merge of rust-lang#52954 - cramertj:async-parse, r=petrochenkov
3e7897f 
async can begin expressions

Fix rust-lang#52951

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petrochenkov @cramertj